Skip to content

Conversation

@elBoberido
Copy link
Member

@elBoberido elBoberido commented Apr 23, 2025

Notes for Reviewer

It seems there was a copy&paste error in the UnixDatagramSender::blocking_send and UnixDatagramSender::timed_send methods. Instead of setting the the socket to blocking, it was set to non-blocking. This PR fixes the bug.

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #698

@elBoberido elBoberido marked this pull request as ready for review April 23, 2025 22:26
@elBoberido elBoberido self-assigned this Apr 23, 2025
@elBoberido elBoberido requested review from elfenpiff and removed request for elfenpiff April 23, 2025 22:37
@elBoberido elBoberido force-pushed the iox2-698-fix-unix-datagram-sender-blocking-send-calls branch from 257160d to 013151a Compare April 25, 2025 17:46
@elBoberido elBoberido force-pushed the iox2-698-fix-unix-datagram-sender-blocking-send-calls branch from 013151a to fc75724 Compare April 25, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'UnixDatagramSender::blocking_send' and 'UnixDatagramSender::timed_send' are set as non-blocking

1 participant