-
Notifications
You must be signed in to change notification settings - Fork 14
feat(aas-list): Show Registry Entries #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NameplateValuesForAAS
…mproved data handling
…ved handling of API responses
GailMelanie
reviewed
Oct 30, 2025
GailMelanie
approved these changes
Oct 30, 2025
pawel-baran-se
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, please solve comments before merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces support for listing Asset Administration Shells (AAS) from both repositories and registries, rather than just repositories. The changes update the UI to allow users to select between repositories and registries, propagate this selection through the component tree, and adjust API calls to fetch AAS lists from the correct source depending on the selected connection type. Additionally, the registry service API and its interface are extended to support paginated fetching of AAS descriptors.
UI changes for repository/registry selection:
SelectRepository.tsx: Refactored to allow selection between repositories and registries, displaying them in grouped dropdown sections. The selected type is now tracked and propagated using a new callback. (src/app/[locale]/list/_components/filter/SelectRepository.tsxL2-R29, src/app/[locale]/list/_components/filter/SelectRepository.tsxL22-R49, src/app/[locale]/list/_components/filter/SelectRepository.tsxL38-R67, src/app/[locale]/list/_components/filter/SelectRepository.tsxL56-R128)AasListDataWrapper.tsx,AasList.tsx,AasListTableRow.tsx: AddedconnectionTypeprop to propagate the selected connection type through the AAS list components. (src/app/[locale]/list/_components/AasList.tsxR10-R19, src/app/[locale]/list/_components/AasListDataWrapper.tsxR31, src/app/[locale]/list/_components/AasListDataWrapper.tsxR154, src/app/[locale]/list/_components/AasListTableRow.tsxR24, src/app/[locale]/list/_components/AasListTableRow.tsxR41)API and data fetching enhancements:
AasListDataWrapper.tsx: Updated AAS list fetching logic to include the selected connection type, enabling correct data retrieval from either a repository or a registry. (src/app/[locale]/list/_components/AasListDataWrapper.tsxL59-R60)registryServiceApi.ts,registryServiceApiInMemory.ts,registryServiceApiInterface.ts: Added a new methodgetAllAssetAdministrationShellDescriptorsto support paginated fetching of AAS descriptors from registries. The interface and in-memory implementation were updated accordingly. [1] [2] [3] [4] [5]Minor bugfixes and improvements:
AasListTableRow.tsx: Improved error logging in property translation to include the property value for easier debugging. (src/app/[locale]/list/_components/AasListTableRow.tsxL91-R94)AasListTableRow.tsx: Adjusted URL parameter logic to only includerepoUrlwhen the connection type is a repository, preventing incorrect parameter usage for registries. (src/app/[locale]/list/_components/AasListTableRow.tsxL69-R74)