test: Pass proto_ver to do_test() functions that require it #3211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These test scripts all contain a `finally:` block that attempts to print
proto_ver which does not exist:
```
print("proto_ver=%d" % (proto_ver))
```
This mistake appears to be a copy-and-paste error in commit b2a9daf ("02
broker subpub tests with v5 support") and went unnoticed because the
code is only reached if the tests fail.
Fixes: b2a9daf ("02 broker subpub tests with v5 support")
Closes: eclipse-mosquitto#3123
|
@ralight: could you please have a look at this trivial PR? |
|
@ralight: I went through the hassle of signing the CLA. Can you have a look now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These test scripts all contain a
finally:block that attempts to print proto_ver which does not exist:This mistake appears to be a copy-and-paste error in commit b2a9daf ("02 broker subpub tests with v5 support") and went unnoticed because the code is only reached if the tests fail.
Fixes: b2a9daf ("02 broker subpub tests with v5 support")
Closes: #3123