Add a FeatureBundle manifest replacement extension #20
Conversation
timothyjward
force-pushed
the
feature/replace
branch
2 times, most recently
from
0a2a051 to
c9b9df4
Compare
This commit adds a utility extension which can be used to replace the manifest of a Feature Bundle being installed. This can be used, for example, to dynamically add a manifest to an artifact which isn't an OSGi bundle, or to correct some metadata. Signed-off-by: Tim Ward <timothyjward@apache.org>
timothyjward
force-pushed
the
feature/replace
branch
from
c9b9df4 to
4718d2d
Compare
extensions/manifest.replacer/src/test/resources/features/not-json-extension.json
Outdated
Show resolved
Hide resolved
| "bundles": [ | ||
| { | ||
| "id": "org.eclipse.osgi.technology.featurelauncher.extensions.manifest.replacer.test:test-bundle:0.0.1", | ||
| "eclipse.osgi.technology.manifest.replacer.Bundle-ManifestVersion": "2", |
There was a problem hiding this comment.
manifest.replacer" : {
"Bundle-ManifestVersion": 2",
...
}
Or altenative write it full
manifest.replacer" : [
"Line1",
"Line2"
]
Or would this be better in a handler that add/Override files in general on a give path.?
Aso with an base64 option?
There was a problem hiding this comment.
manifest.replacer" : { "Bundle-ManifestVersion": 2", ... }
Or altenative write it full
manifest.replacer" : [ "Line1", "Line2" ]
Both of these would violate the Feature specification
"Bundle metadata supports string keys and string, number or boolean values."
This is the reason for having a prefix. It's not pretty, but it stays within the specification.
Or would this be better in a handler that add/Override files in general on a give path.? Aso with an base64 option?
I don't think we want to add additional files into the mix. The point of a feature is that it is a single document describing the deployment. If we add an extra file then we'll need to work out how to keep that alongside the feature document.
Use a more meaningful name in the test Feature JSON file
|
This commit adds a utility extension which can be used to replace the manifest of a Feature Bundle being installed. This can be used, for example, to dynamically add a manifest to an artifact which isn't an OSGi bundle, or to correct some metadata.