Skip to content

Conversation

@stbischof
Copy link
Contributor

No description provided.

@stbischof
Copy link
Contributor Author

@timothyjward

Could you give me your general thoughts on that.

@timothyjward timothyjward self-requested a review February 7, 2024 10:32
Copy link
Contributor

@timothyjward timothyjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks promising, but I think it needs tidying up a little. There are a few things which are currently public which I think should probably not be considered API (and therefore need to be default visibility).

@stbischof stbischof force-pushed the assertj_cm branch 3 times, most recently from 7b89f18 to f332337 Compare February 7, 2024 16:45
Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
@stbischof
Copy link
Contributor Author

stbischof commented Feb 9, 2024

@timothyjward I am Ready with this PR

Here are some examples of how the conditions we publish could describe a Assert-Result:

[✓] pid is <null>


[✗] pid is <null> was <thePid>


[✓] all of:[
   [✓] type is <CM_UPDATED>,
   [✓] factoryPid equals <theFactoryPid>
]


[✗] all of:[
   [✓] type is <CM_UPDATED>,
   [✗] factoryPid equals <otherFactoryPid> was <theFactoryPid>
]


[✗] all of:[
   [✗] type is <CM_DELETED> was <CM_UPDATED>,
   [✓] factoryPid equals <theFactoryPid>
]


[✓] factoryPid is <null>


[✗] factoryPid is <null> was <theFactoryPid>


[✓] type is <CM_UPDATED>


[✗] type is <CM_UPDATED> was <CM_DELETED>


[✓] any of:[
   [✗] all of:[
      [✗] not :<pid is <null>>,
      [✓] pid equals <null>
   ],
   [✓] all of:[
      [✓] not :<factoryPid is <null> was <theFactoryPid>>,
      [✓] factoryPid equals <theFactoryPid>
   ]
]


[✓] any of:[
   [✓] all of:[
      [✓] not :<pid is <null> was <thePid>>,
      [✓] pid equals <thePid>
   ],
   [✗] all of:[
      [✗] not :<factoryPid is <null>>,
      [✓] factoryPid equals <null>
   ]
]


[✗] any of:[
   [✗] all of:[
      [✗] not :<pid is <null>>,
      [✓] pid equals <null>
   ],
   [✗] all of:[
      [✓] not :<factoryPid is <null> was <otherFactoryPid>>,
      [✗] factoryPid equals <theFactoryPid> was <otherFactoryPid>
   ]
]


[✗] any of:[
   [✗] all of:[
      [✓] not :<pid is <null> was <otherPid>>,
      [✗] pid equals <thePid> was <otherPid>
   ],
   [✗] all of:[
      [✗] not :<factoryPid is <null>>,
      [✓] factoryPid equals <null>
   ]
]


[✓] factoryPid equals <theFactoryPid>


[✗] factoryPid equals <theFactoryPid> was <otherFactoryPid>


[✗] factoryPid equals <theFactoryPid> was <null>


[✓] factoryPid equals <thePid>


[✗] factoryPid equals <thePid> was <otherPid>

[✗] factoryPid equals <thePid> was <null>

[✓] all of:[
   [✓] type is <CM_UPDATED>,
   [✓] pid equals <thePid>
]


[✗] all of:[
   [✓] type is <CM_UPDATED>,
   [✗] pid equals <otherPid> was <thePid>
]


[✗] all of:[
   [✗] type is <CM_DELETED> was <CM_UPDATED>,
   [✓] pid equals <thePid>
]

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be closed if no further activity occurs. If you intend to work on this pull request, please reopen the PR. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 27, 2025
@stbischof stbischof removed the stale label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants