Subscribe should not return null (#262) #383
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always returning null breaks the contract set in the function signature and documentation. This affects all subscribes that receive `IMqttMessageListener` as parameter. Signed-off-by: Fernando Governatore <affqlixo+eclipse@gmail.com>
Governa
force-pushed
the
null_on_subscribe_return
branch
from
6eedef3 to
f19ada0
Compare
On subscribe, a failure would be reported but onSuccess would never be called. The reason was not passing the IMqttActionListener forward to MqttClient. Signed-off-by: Fernando Governatore <affqlixo+eclipse@gmail.com>
Governa
force-pushed
the
null_on_subscribe_return
branch
from
da0468d to
d87453c
Compare
|
Is this patch acceptable? Is there anything missing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always returning null breaks the contract set in the function signature
and documentation.
This affects all subscribes that receive
IMqttMessageListeneras parameter.Please make sure that the following boxes are checked before submitting your Pull Request, thank you!