Skip to content

Subscribe should not return null (#262) #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Subscribe should not return null (#262) #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f19ada0
Subscribe should not return null (#262)
Oct 5, 2019
d87453c
Should pass IMqttActionListener on subscribe (#262)
Oct 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...aho.android.service/src/main/java/org/eclipse/paho/android/service/MqttAndroidClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,7 +1146,7 @@ public IMqttToken subscribe(String[] topicFilters, int[] qos, Object userContext
String activityToken = storeToken(token);
mqttService.subscribe(clientHandle, topicFilters, qos, null, activityToken, messageListeners);

return null;
return token;
}


Expand Down
2 changes: 1 addition & 1 deletion ...e.paho.android.service/src/main/java/org/eclipse/paho/android/service/MqttConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,7 @@ public void subscribe(String[] topicFilters, int[] qos, String invocationContext
IMqttActionListener listener = new MqttConnectionListener(resultBundle);
try {

myClient.subscribe(topicFilters, qos,messageListeners);
myClient.subscribe(topicFilters, qos, null, listener, messageListeners);
} catch (Exception e){
handleException(resultBundle, e);
}
Expand Down