Wrong target link libraries names for static libs, which breaks configure

[barracuda156]

If I enable static and dynamic libs both, configure fails:

--->  Configuring paho.mqtt.cpp
        (using ccache)
Executing:  cd "/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_net_paho.mqtt.cpp/paho.mqtt.cpp/work/build" && /opt/local/bin/cmake -G "CodeBlocks - Unix Makefiles" -DCMAKE_BUILD_TYPE=MacPorts -DCMAKE_INSTALL_PREFIX="/opt/local" -DCMAKE_INSTALL_NAME_DIR="/opt/local/lib" -DCMAKE_SYSTEM_PREFIX_PATH="/opt/local;/usr" -DCMAKE_C_COMPILER_LAUNCHER=/opt/local/bin/ccache -DCMAKE_CXX_COMPILER_LAUNCHER=/opt/local/bin/ccache -DCMAKE_Fortran_COMPILER_LAUNCHER=/opt/local/bin/ccache -DCMAKE_OBJC_COMPILER_LAUNCHER=/opt/local/bin/ccache -DCMAKE_OBJCXX_COMPILER_LAUNCHER=/opt/local/bin/ccache -DCMAKE_ISPC_COMPILER_LAUNCHER=/opt/local/bin/ccache -DCMAKE_C_COMPILER="$CC" -DCMAKE_CXX_COMPILER="$CXX" -DCMAKE_OBJC_COMPILER="$CC" -DCMAKE_OBJCXX_COMPILER="$CXX" -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_POLICY_DEFAULT_CMP0060=NEW -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_COLOR_MAKEFILE=ON -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_MAKE_PROGRAM=/usr/bin/make -DCMAKE_MODULE_PATH="/opt/local/share/cmake/Modules" -DCMAKE_PREFIX_PATH="/opt/local/share/cmake/Modules" -DCMAKE_BUILD_WITH_INSTALL_RPATH:BOOL=ON -DCMAKE_INSTALL_RPATH="/opt/local/lib" -Wno-dev -DPAHO_BUILD_SHARED=ON -DPAHO_BUILD_STATIC=ON -DPAHO_WITH_SSL=ON -DOPENSSL_ROOT_DIR=/opt/local/libexec/openssl3 -DOPENSSL_INCLUDE_DIR=/opt/local/libexec/openssl3/include -DWITH_SSL=/opt/local/libexec/openssl3 -DCMAKE_OSX_ARCHITECTURES="ppc" -DCMAKE_OSX_DEPLOYMENT_TARGET="10.6" -DCMAKE_OSX_SYSROOT="/" /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_net_paho.mqtt.cpp/paho.mqtt.cpp/work/paho.mqtt.cpp-1.4.1 
-- The C compiler identification is GNU 14.2.0
-- The CXX compiler identification is GNU 14.2.0
-- Checking whether C compiler has -isysroot
-- Checking whether C compiler has -isysroot - yes
-- Checking whether C compiler supports OSX deployment target flag
-- Checking whether C compiler supports OSX deployment target flag - yes
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /opt/local/bin/gcc-mp-14 - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Checking whether CXX compiler has -isysroot
-- Checking whether CXX compiler has -isysroot - yes
-- Checking whether CXX compiler supports OSX deployment target flag
-- Checking whether CXX compiler supports OSX deployment target flag - yes
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /opt/local/bin/g++-mp-14 - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found OpenSSL: /opt/local/libexec/openssl3/lib/libcrypto.dylib (found version "3.3.2")
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Configuring done (9.4s)
CMake Error at src/CMakeLists.txt:82 (target_link_libraries):
  Target "paho-mqttpp3-static" links to:

    eclipse-paho-mqtt-c::paho-mqtt3as-static

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.



-- Generating done (0.1s)
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_OBJCXX_COMPILER
    CMAKE_OBJC_COMPILER
    CMAKE_POLICY_DEFAULT_CMP0025
    CMAKE_POLICY_DEFAULT_CMP0060
    WITH_SSL


CMake Generate step failed.  Build files cannot be regenerated correctly.

Looks like target link libraries names are wrong. What is actually installed by paho.mqtt.c:

36-202% port contents paho.mqtt.c
Port paho.mqtt.c @1.3.13_1 contains:
  /opt/local/bin/MQTTVersion
  /opt/local/include/MQTTAsync.h
  /opt/local/include/MQTTClient.h
  /opt/local/include/MQTTClientPersistence.h
  /opt/local/include/MQTTExportDeclarations.h
  /opt/local/include/MQTTProperties.h
  /opt/local/include/MQTTReasonCodes.h
  /opt/local/include/MQTTSubscribeOpts.h
  /opt/local/lib/cmake/eclipse-paho-mqtt-c/eclipse-paho-mqtt-cConfig-macports.cmake
  /opt/local/lib/cmake/eclipse-paho-mqtt-c/eclipse-paho-mqtt-cConfig.cmake
  /opt/local/lib/cmake/eclipse-paho-mqtt-c/eclipse-paho-mqtt-cConfigVersion.cmake
  /opt/local/lib/libpaho-mqtt3a.1.3.13.dylib
  /opt/local/lib/libpaho-mqtt3a.1.dylib
  /opt/local/lib/libpaho-mqtt3a.a
  /opt/local/lib/libpaho-mqtt3a.dylib
  /opt/local/lib/libpaho-mqtt3as.1.3.13.dylib
  /opt/local/lib/libpaho-mqtt3as.1.dylib
  /opt/local/lib/libpaho-mqtt3as.a
  /opt/local/lib/libpaho-mqtt3as.dylib
  /opt/local/lib/libpaho-mqtt3c.1.3.13.dylib
  /opt/local/lib/libpaho-mqtt3c.1.dylib
  /opt/local/lib/libpaho-mqtt3c.a
  /opt/local/lib/libpaho-mqtt3c.dylib
  /opt/local/lib/libpaho-mqtt3cs.1.3.13.dylib
  /opt/local/lib/libpaho-mqtt3cs.1.dylib
  /opt/local/lib/libpaho-mqtt3cs.a
  /opt/local/lib/libpaho-mqtt3cs.dylib
  /opt/local/share/doc/Eclipse Paho C/CONTRIBUTING.md
  /opt/local/share/doc/Eclipse Paho C/README.md
  /opt/local/share/doc/Eclipse Paho C/edl-v10
  /opt/local/share/doc/Eclipse Paho C/epl-v20
  /opt/local/share/doc/Eclipse Paho C/notice.html
  /opt/local/share/doc/Eclipse Paho C/samples/MQTTAsync_publish.c
  /opt/local/share/doc/Eclipse Paho C/samples/MQTTAsync_publish_time.c
  /opt/local/share/doc/Eclipse Paho C/samples/MQTTAsync_subscribe.c
  /opt/local/share/doc/Eclipse Paho C/samples/MQTTClient_publish.c
  /opt/local/share/doc/Eclipse Paho C/samples/MQTTClient_publish_async.c
  /opt/local/share/doc/Eclipse Paho C/samples/MQTTClient_subscribe.c
  /opt/local/share/doc/Eclipse Paho C/samples/paho_c_pub.c
  /opt/local/share/doc/Eclipse Paho C/samples/paho_c_sub.c
  /opt/local/share/doc/Eclipse Paho C/samples/paho_cs_pub.c
  /opt/local/share/doc/Eclipse Paho C/samples/paho_cs_sub.c
  /opt/local/share/doc/Eclipse Paho C/samples/pubsub_opts.c

[fpagliughi]

Yes. This is discussed in #500... here

We're still waiting on a release of the upstream Paho C library for the full fix. Soon, I hope.

[fpagliughi]

Seems like the C lib is finally approaching a release. This fix will be available in Paho C++ v1.5.0

[PreetM07]

I am adding a comment to this closed issue.
I am not well versed with make but I was able to build the pahomqttcpp using #500... #500 (comment)

however when I am trying to build my own project
I am facing the following error
cmake --build build --config Release
MSBuild version 17.12.12+1cce77968 for .NET Framework

LINK : fatal error LNK1181: cannot open input file 'paho-mqttpp3.lib' [D:\Repository\NBD IOT\demo POC\build\SensorSimulator.vcxproj]

I am on a windows and what I see is there is no paho-mqttpp3.lib in C:\Program Files (x86)\PahoMqttCpp\lib (this seemed to be the default install path)
however it has paho-mqttpp3-static.lib

any suggestions?

[fpagliughi]

On Windows, dynamic (shared) DLL libraries require an associated import library with a .lib extension. So, for this library, the files paho-mqttpp3.dll and paho-mqttpp3.lib are for the shared library.

So we need a different name for the static library. We named it paho-mqttpp3-static.lib

By default, on Windows, CMake configures to just build the static library, which is why you're just seeing the static lib file. If you re-run CMake and specify -DPAHO_BUILD_SHARED=ON, then rebuild, you will also get the DLL and it's import file

[PreetM07]

So, please correct me if I am wrong
I did build the libs with two different configs

1. Static build
   cmake -Bbuild -H. -DPAHO_WITH_MQTT_C=ON -DPAHO_BUILD_EXAMPLES=ON -DPAHO_BUILD_STATIC=ON -DPAHO_BUILD_SHARED=OFF

and then install...
cmake --build build/ --target install

2. shared build
   cmake -Bbuild -H. -DPAHO_WITH_MQTT_C=ON -DPAHO_BUILD_EXAMPLES=ON -DPAHO_BUILD_STATIC=OFF -DPAHO_BUILD_SHARED=ON

and then install...
cmake --build build/ --target install

---

the 1st one builds good without any issues generating lib with static in its name in the path I mentioned...
the 2nd one doesn't go through
many errors...
I am just posting one here
paho-mqttpp3-shared.vcxproj -> D:\Repository\NBD IOT\paho.mqtt.cpp\build\src\Debug\paho-mqttpp3.dll
async_consume.cpp
async_consume.obj : error LNK2001: unresolved external symbol "private: static class std::basic_string<char,struct std:
:char_traits,class std::allocator > const mqtt::message::EMPTY_STR" (?EMPTY_STR@message@mqtt@@0V?$basic_str
ing@DU?$char_traits@D@std@@v?$allocator@D@2@@std@@b) [D:\Repository\NBD IOT\paho.mqtt.cpp\build\examples\async_consume.
vcxproj]
D:\Repository\NBD IOT\paho.mqtt.cpp\build\examples\Debug\async_consume.exe : fatal error LNK1120: 1 unresolved external
s [D:\Repository\NBD IOT\paho.mqtt.cpp\build\examples\async_consume.vcxproj]

so these errors looks like in the example and I believe the examples are not shared dll supportive?
I build with PAHO_BUILD_EXAMPLES=OFF and it passes through...

one more update is

cmake -Bbuild -H. -DPAHO_WITH_MQTT_C=ON -DPAHO_BUILD_EXAMPLES=ON -DPAHO_BUILD_STATIC=OFF -DPAHO_BUILD_SHARED=ON

by default seems to build with the debug config?
which is generating the libs that are not working with my app's release build

if I build and install with
cmake -Bbuild -H. -DPAHO_WITH_MQTT_C=ON -DPAHO_BUILD_EXAMPLES=ON -DCMAKE_BUILD_TYPE=Release
cmake --build build --config Release --target install

this lib is working well with release...

[fpagliughi]

OK. I recreated the problem. In fixing a problem for Clang I broke the Windows DLL build.

This happened by moving some string constants out of the functions and into message class static variables in v1.5.1 which I released earlier this week.

If you're using Windows, you can revert back to v1.5.0 of this library safely for now until I can get a release to fix it. In Windows, class static constants must be manually exported from a DLL. For some reason the CMake "export all" option for Windows doesn't seem to apply to class static constants!