Skip to content

Broken playwright test on Windows using TheiaTextEditor #15447

Open
@Hanksha

Description

@Hanksha

Bug Description:

Since the changes in #14764 our tests using the TheiaTextEditor are failing on Windows at await editor.waitForVisible().
I investigated it and the expected viewSelector and tabSelector are different from the actual.

Actual in Browser:
code-editor-opener:file:///c%3A/Users/Vivien/martini-designer-e2e-tests/.gitignore:1
Expected by TheiaTextEditor:
code-editor-opener:file://c%3A/Users/Vivien/martini-designer-e2e-tests/.gitignore:1

It looks like the path returned by TheiaWorkspace.escapedPath (which calls TheiaWorkspace.path) lost a leading / for Windows which causes TheiaTextEditor to generate incorrect selectors.

Steps to Reproduce:

  1. Run a playwright test that open a file.
  2. Create TheiaTextEditor pointing to the opened file.
  3. use await editor.waitForVisible()
  4. This will timeout.

Additional Information

  • Operating System:
  • Theia Version: 1.60.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions