-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add a suggestion to Architect to summarize the current session and continue with Coder #15512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Jonas Helming <jhelming@eclipsesource.com>
Co-authored-by: Jonas Helming <jhelming@eclipsesource.com>
Co-authored-by: Jonas Helming <jhelming@eclipsesource.com>
|
||
import { Command } from '@theia/core'; | ||
|
||
export const AI_SUMMARIZE_SESSION_AS_TASK_FOR_CODER: Command = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going with a command even though I set up the callback system!? ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this, because I wanted to have the nice progress bar, so it felt natural. I would use call back for actions that stay within the session for example pre-defined user message. Does this make sense to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command approach was my preference, so I'm happy either way. Re: the progress bar, its display is part of the behavior of TaskContextService.summarize
, so as long as you call that, whether in a command or a callback, you should get the progress bar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is good to support both!
Do you have any other comments on this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No - not sure if it makes sense to approve it while #15427 is still pending? Or would you like this to go in instead?
Co-authored-by: colin-grant-work <cgrant.ext@eclipsesource.com>
Co-authored-by: colin-grant-work <cgrant.ext@eclipsesource.com>
Co-authored-by: colin-grant-work <cgrant.ext@eclipsesource.com>
Co-authored-by: colin-grant-work <cgrant.ext@eclipsesource.com>
What it does
based on #15427
How to test
Follow-ups
Coder could immediatly start to implement or at least provide this as a suggestion
Breaking changes
Attribution
Review checklist
Reminder for reviewers