Skip to content

Conversation

@ammarwa
Copy link

@ammarwa ammarwa commented Feb 28, 2025

What it does

The Perfetto trace format is being used today for many profiling and tracing tools, such as rocprofv3 for AMD GPUs profiling and tracing, Android traces, and Chrome traces.

This PR adds Protobuf (Perfetto format precisely) support for TraceCompass to visualize traces that can be visualized using Perfetto UI.

How to test

Provided binary trace output file that will be used in the tests to read that trace and ensure we can analyze it correctly.

Follow-ups

More work must be done to make it efficient and optimized for reading protobuf traces. Also, more work needs to be done to add more visualization that can match the needs of the traces that use the Perfetto format. Also, more work is required on testing and validation.

Review checklist

  • As an author, I have thoroughly tested my changes and carefully followed the instructions in this template

Copy link
Contributor

@arfio arfio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows Trace Compass to support another trace format, great work!
There is one additional thing, the com.google.protobuf package should be added to trace compass target in common/org.eclipse.tracecompass.incubator.target/tracecompass-incubator-master.target.
Something like this:

<location includeDependencyDepth="none" includeSource="true" missingManifest="generate" type="Maven">
    <dependencies>
        <dependency>
            <groupId>com.google.protobuf</groupId>
            <artifactId>protobuf-java</artifactId>
            <version>4.29.3</version>
            <type>jar</type>
        </dependency>
    </dependencies>
</location>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not needed ?

Copy link
Contributor

@arfio arfio May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be moved to src/org/eclipse/tracecompass/incubator/perfetto/core/tests/PerfettoTest.java to match the package name

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file and all the other source files for this plugin should be moved from src/org/eclipse/tracecompass/internal/perfetto/core to src/org/eclipse/tracecompass/incubator/internal/perfetto/core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants