-
Notifications
You must be signed in to change notification settings - Fork 23
InAndOutDataProviderFactory extends AbstractTmfDataProviderConfigurator #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
InAndOutDataProviderFactory extends AbstractTmfDataProviderConfigurator #167
Conversation
|
NOTES:
|
bhufmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. I added some comments,
| * the trace to apply it to | ||
| * @param writeConfig | ||
| * write the config (do only once) | ||
| * @return InAndOutAnalysisModule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a void method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| * @throws TmfConfigurationException | ||
| * if an error occurs | ||
| */ | ||
| private void create(@NonNull ITmfConfiguration config, @NonNull ITmfTrace trace, boolean writeConfig, IAnalysisModule module) throws TmfConfigurationException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the class is NonNullByDefault, so you can remove the null annotations from the method parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Make create private
9c744a5 to
fa57b5d
Compare
What it does
Refactor the InAndOutDataProviderFactory to use the proposed api for configurable data provider factories in org.eclipse.tracecompass PR 235.
Benefit that I think this PR introduces:
How to test
Test will be added if the proposal is accepted.
Checkout org.eclipse.tracecompass PR 235 and incubator PR. Then try to use the InAndOutDataProviderFactory as usual (e.g. by using the tsp-python-client). Can add more explicit instructions if needed.
Follow-ups
Depending on the discussions around this proposal, add documentation on how one can create a new configurable data provider factory using the proposed API.
Review checklist