refactor: simplify environment variable handling by removing window.ENV initialization

Author: matbmoser

ichub-frontend/src/services/EnvironmentService.ts

@@ -20,21 +20,6 @@
  * SPDX-License-Identifier: Apache-2.0
 ********************************************************************************/
 
-/// <reference types="vite/client" />
-
-// Extend Window interface for runtime environment variables
-declare global {
-  interface Window {
-    ENV?: {
-      REQUIRE_HTTPS_URL_PATTERN?: string;
-      ICHUB_BACKEND_URL?: string;
-      PARTICIPANT_ID?: string;
-      GOVERNANCE_CONFIG?: string;
-      DTR_POLICIES_CONFIG?: string;
-    }
-  }
-}
-
 // Types for governance configuration
 export interface GovernanceConstraint {
   leftOperand: string;
@@ -60,70 +45,13 @@ export interface GovernanceConfig {
   policies: GovernancePolicy[];
 }
 
-/**
- * Ensures window.ENV is properly initialized
- * This function can be called to guarantee ENV is available before accessing it
- */
-const ensureWindowEnvInitialized = () => {
-  if (!window.ENV) {
-    console.warn('window.ENV not found, initializing with fallback values');
-    window.ENV = {
-      REQUIRE_HTTPS_URL_PATTERN: import.meta.env.VITE_REQUIRE_HTTPS_URL_PATTERN || 'false',
-      ICHUB_BACKEND_URL: import.meta.env.VITE_ICHUB_BACKEND_URL || '',
-      PARTICIPANT_ID: import.meta.env.VITE_PARTICIPANT_ID || '',
-      GOVERNANCE_CONFIG: import.meta.env.VITE_GOVERNANCE_CONFIG || '[]',
-      DTR_POLICIES_CONFIG: import.meta.env.VITE_DTR_POLICIES_CONFIG || '[]'
-    };
-  }
-};
-
-export const isRequireHttpsUrlPattern = () => {
-  ensureWindowEnvInitialized();
-  return window?.ENV?.REQUIRE_HTTPS_URL_PATTERN !== 'false';
-};
+export const isRequireHttpsUrlPattern = () =>
+  import.meta.env.VITE_REQUIRE_HTTPS_URL_PATTERN !== 'false';
 
-export const getIchubBackendUrl = () => {
-  ensureWindowEnvInitialized();
-  
-  // Debug: Log what's available
-  
-  
-  
-  
-  
-  // First try to get from window.ENV (runtime injection via Helm charts), then fallback to build-time env
-  const backendUrl = window?.ENV?.ICHUB_BACKEND_URL || 
-                     import.meta.env.VITE_ICHUB_BACKEND_URL;
-  
-  
-  
-  if (!backendUrl) {
-    console.warn('❌ ICHUB_BACKEND_URL not configured. Ensure environment variable is set via Helm chart or build configuration.');
-  }
-  
-  return backendUrl;
-};
-export const getParticipantId = () => {
-  ensureWindowEnvInitialized();
-  
-  // Debug: Log what's available
-  
-  
-  
-  
-  // First try to get from window.ENV (runtime injection via Helm charts), then fallback to build-time env
-  const participantId = window?.ENV?.PARTICIPANT_ID || 
-                        import.meta.env.VITE_PARTICIPANT_ID;
-  
-  // Use fallback value if no participant ID is configured
-  const resolvedId = participantId ?? 'BPNL0000000093Q7';
-  
-  
-  return resolvedId;
-};
+export const getIchubBackendUrl = () => import.meta.env.VITE_ICHUB_BACKEND_URL ?? '';
+export const getParticipantId = () => import.meta.env.VITE_PARTICIPANT_ID ?? 'BPNL0000000093Q7';
 
 export const getGovernanceConfig = (): GovernanceConfig[] => {
-  ensureWindowEnvInitialized();
   try {
     // First try to get from window.ENV (runtime injection), then fallback to import.meta.env
     const configStr = window?.ENV?.GOVERNANCE_CONFIG || import.meta.env.VITE_GOVERNANCE_CONFIG;
@@ -136,7 +64,6 @@ export const getGovernanceConfig = (): GovernanceConfig[] => {
 };
 
 export const getDtrPoliciesConfig = (): GovernancePolicy[] => {
-  ensureWindowEnvInitialized();
   try {
     // First try to get from window.ENV (runtime injection), then fallback to import.meta.env
     const configStr = window?.ENV?.DTR_POLICIES_CONFIG || import.meta.env.VITE_DTR_POLICIES_CONFIG;
@@ -216,4 +143,4 @@ const EnvironmentService = {
   getDtrPoliciesConfig
 };
 
-export default EnvironmentService;
+export default EnvironmentService;