feat: Added sample database model based on DRÄXLMAIER implementation #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matbmoser
requested changes
Feb 13, 2025
ichub-backend/models/example_drx.py
Outdated
| ################################################################################# | ||
| # Eclipse Tractus-X - Industry Core Hub Backend | ||
| # | ||
| # Copyright (c) Lisa Dräxlmaier GmbH |
There was a problem hiding this comment.
Suggested change
| # Copyright (c) Lisa Dräxlmaier GmbH | |
| # Copyright (c) 2025 Dräxlmaier GmbH |
There was a problem hiding this comment.
I would include it like this so is more generic, BMW and other companies also not specify which company of the group are, example:
You can add the (represented by) but I think is not really necessary.
There was a problem hiding this comment.
Hi Mathias,
I will chose the "represented" way.
Unfortunately I don't have the internal mandate to speak for the company group.
(Legal stuff).
There was a problem hiding this comment.
that's fine, just not forget the year we are doing this, it should also appear.
the 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a sample database model for discussion. It is based on the ideas and concepts implemented in DRÄXLMAIER's own industry core solution.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: