Skip to content

Conversation

samuelroywork
Copy link
Contributor

Description

Configured pgadmin as chart dependency to deploy along with industry core hub.

Used portal helm chart as reference: https://github.com/eclipse-tractusx/portal/blob/main/charts/portal/values.yaml

Issue: #79

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link

sonarqubecloud bot commented Mar 6, 2025

enabled: true
ingressClassName: "nginx"
hosts:
- host: pgadmin4.tx.test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matbmoser, what do you think about using this ingress?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change it

Copy link
Contributor

@gomezbc gomezbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please run helm-docs in the chart directory to update the README

https://github.com/norwoodj/helm-docs?tab=readme-ov-file#installation

Copy link
Contributor

@matbmoser matbmoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please disable the ingress.

@samuelroywork can you also add in the values-int.yaml the override to the ingress with the url: pgadmin-ichub.int.catena-x.net

@CDiezRodriguez CDiezRodriguez marked this pull request as ready for review March 12, 2025 08:58
@matbmoser matbmoser merged commit 8b5fbdf into eclipse-tractusx:main Mar 12, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants