Skip to content

Conversation

@eschrewe
Copy link
Contributor

@eschrewe eschrewe commented Oct 1, 2024

Description

  • the "findAllByFilters" methods were heavily reliant on using the repositories' "findAll" methods. This will cause avoidable performance issues, when a larger number of entities is stored in the databases
  • created parametrized requests for the repositories, which are now used instead
  • added validation checks for the "update" methods in the services

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant