Skip to content

Conversation

ReneSchroederLJ
Copy link
Member

@ReneSchroederLJ ReneSchroederLJ commented Aug 13, 2025

Description

  • updated Arc42 to better represent the current state of the application

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the rigorous efforts! One thing to add a few things of taste (I would go for autoformatted tables) :)

@ReneSchroederLJ
Copy link
Member Author

I've auto formatted the tables as requested.

While doing that I realized that the current configuration of the repo will auto format lists with an indentation of 4 which is quite unusual for markdown and causes markdownlint to complain. I added a rule for markdown files to the .editorconfig file to set the indentation to 2.

Now auto formatting is in line with typical markdown conventions.

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your update! Found one version mismatch I missed earlier. Please adjust and merge main to merge :)

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit e38ed74 into eclipse-tractusx:main Aug 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants