Skip to content

Conversation

OlgaIvkovic
Copy link
Contributor

@OlgaIvkovic OlgaIvkovic commented Aug 20, 2025

Description

  • Fixed issue of not being able to resolve notification due to an empty text
  • Added validation checks against only white spaces in both text and resolution message

Solves issue: #950

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

@OlgaIvkovic OlgaIvkovic self-assigned this Aug 20, 2025
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! LGTM! Noticed #953 during test.

Sidenote: Following conventional commit you don't need to specify the empty brackets if you don't specify a scope.

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 61b686e into eclipse-tractusx:main Aug 21, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants