Skip to content

Conversation

ReneSchroederLJ
Copy link
Member

@ReneSchroederLJ ReneSchroederLJ commented Sep 11, 2025

Description

  • fixed a wrong constraint in the DTR framework policy within the bruno collection
  • fixed minor bruno script issues

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Please check comment to align on how to proceed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't provide a migration in the documentation or somewhere. I would opt to exclude this change in this PR. How about you?

If we change it, we need some kind of guidance for migration + we then can enable the policy validation in the local deployment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you. This should be handled and properly documented separately. I've removed the change for now

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 3d70637 into eclipse-tractusx:main Sep 24, 2025
13 checks passed
tom-rm-meyer-ISST pushed a commit that referenced this pull request Oct 9, 2025
…988)

* fix/bruno dtr setup (#967)

* fix: dtr framework policy in bruno

* fix: added missing access policy namespaces

* chore: updated changelog

* fix: revert policy creation fix to preserve existing policy definitions

* fix(frontend): handle data modal context correctly to update after deleting entries (#984)

* fixed the tables not updating after deleting rows in different modals of the dataModalContext

* chore: update changelog

* chore: moved to the correct part of changelog

* feat: implemented multi profile support for backwards compatibility

* fix: properly separated JsonLd context by profile

* fix: minor improvements

* chore: add new jsonld files to remote contexts in notice

---------

Co-authored-by: OlgaIvkovic <olga.ivkovic@8020.eco>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants