-
Notifications
You must be signed in to change notification settings - Fork 13
Fix/bruno dtr setup #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/bruno dtr setup #967
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. Please check comment to align on how to proceed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't provide a migration in the documentation or somewhere. I would opt to exclude this change in this PR. How about you?
If we change it, we need some kind of guidance for migration + we then can enable the policy validation in the local deployment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you. This should be handled and properly documented separately. I've removed the change for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
…988) * fix/bruno dtr setup (#967) * fix: dtr framework policy in bruno * fix: added missing access policy namespaces * chore: updated changelog * fix: revert policy creation fix to preserve existing policy definitions * fix(frontend): handle data modal context correctly to update after deleting entries (#984) * fixed the tables not updating after deleting rows in different modals of the dataModalContext * chore: update changelog * chore: moved to the correct part of changelog * feat: implemented multi profile support for backwards compatibility * fix: properly separated JsonLd context by profile * fix: minor improvements * chore: add new jsonld files to remote contexts in notice --------- Co-authored-by: OlgaIvkovic <olga.ivkovic@8020.eco>
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:
If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).