-
Notifications
You must be signed in to change notification settings - Fork 13
feat: DCP issuance flow with request way #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
thackerronak
wants to merge
30
commits into
eclipse-tractusx:main
Choose a base branch
from
Cofinity-X:feat/CS-3566-dcp-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: DCP issuance flow with request way #395
thackerronak
wants to merge
30
commits into
eclipse-tractusx:main
from
Cofinity-X:feat/CS-3566-dcp-integration
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/externalservices/Wallet.Service/BusinessLogic/WalletBusinessLogic.cs
Fixed
Show fixed
Hide fixed
src/externalservices/Wallet.Service/BusinessLogic/WalletBusinessLogic.cs
Fixed
Show fixed
Hide fixed
tests/processes/CredentialProcess.Library.Tests/CredentialCreationProcessHandlerTests.cs
Fixed
Show fixed
Hide fixed
tests/processes/CredentialProcess.Library.Tests/CredentialCreationProcessHandlerTests.cs
Fixed
Show fixed
Hide fixed
…entry-ssi-credential-issuer into feat/CS-3566-dcp-integration
IP check ticket: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/22630 |
src/database/SsiCredentialIssuer.Entities/AuditEntities/AuditCompanySsiDetail20240618.cs
Show resolved
Hide resolved
src/processes/CredentialProcess.Library/Creation/CredentialCreationProcessHandler.cs
Outdated
Show resolved
Hide resolved
src/processes/CredentialProcess.Library/Creation/CredentialCreationProcessHandler.cs
Outdated
Show resolved
Hide resolved
src/processes/CredentialProcess.Library/Creation/CredentialCreationProcessHandler.cs
Outdated
Show resolved
Hide resolved
nitin-vavdiya
requested changes
Jul 30, 2025
src/database/SsiCredentialIssuer.DbAccess/Repositories/CredentialRepository.cs
Outdated
Show resolved
Hide resolved
src/database/SsiCredentialIssuer.Migrations/Migrations/IssuerDbContextModelSnapshot.cs
Outdated
Show resolved
Hide resolved
nitin-vavdiya
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
leandro-cavalcante
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merge postponed
the merge of this PR shall be postponed until all prerequisites are fulfilled
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DCP issuance flow with request way
Why
To address this issue, the Decentralized Claims Protocol (DCP) issuance flow is proposed to be the Catena-X Standard for issuing Verifiable Credentials (VC).
Issue
1160
Checklist
Please delete options that are not relevant.