Skip to content

Conversation

nitin-vavdiya
Copy link

Description

  • Log added in the the ExpiryCheckService in case of error

Why

  • We can get the error log in the console, so we don't have to check a database for errors

Issue

#403

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

Comment on lines 133 to +137
}
else
catch (Exception ex)
{
await HandleNotification(data, companySsiDetailsRepository, portalService, cancellationToken).ConfigureAwait(false);
var message = $"Failed to process credential with ID '{data.Id}': {ex.Message}";
throw new InvalidOperationException(message, ex);

Check notice

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant