-
Notifications
You must be signed in to change notification settings - Fork 45
feat: Add optional cert issuer and TLS settings #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ds-jkreutzfeld
wants to merge
14
commits into
eclipse-tractusx:main
Choose a base branch
from
ds-jkreutzfeld:feature/add-cert-issuer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Add optional cert issuer and TLS settings #322
ds-jkreutzfeld
wants to merge
14
commits into
eclipse-tractusx:main
from
ds-jkreutzfeld:feature/add-cert-issuer
+700
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in umbrella chart
Add information about ACME issuer and new TLS values
5386d59
to
608b593
Compare
Hi @mgarciaLKS did you have a chance to review this PR already? |
Still on it, by the end of the week will have it tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the Umbrella Chart with TLS configuration support, making it easier to deploy a secure Tractus-X environment with HTTPS.
1. Added Comprehensive TLS Configuration Example
values-tls.yaml
2. Enhanced TLS Documentation
.test
3. Fixed Ingress and TLS Configuration Issues
sdfactory.tx.test.net
withsdfactory.tx.test
)4. Improved Default Values
Usage
Users can now enable TLS in two ways:
helm upgrade --install umbrella charts/umbrella --namespace umbrella -f charts/umbrella/values-tls.yaml
docs/user/network/tls.md
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: