fix: remove problematic versionService from dspversionparams request #2294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgblaumeiser
pushed a commit
that referenced
this pull request
Sep 30, 2025
…2294) * fix: remove problematic versionService from dspversionparams request * fix: formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Replaces dsp version request delegation from
versionServiceto direct http call.WHY
The
versionServicewill dispatch the request through the dsp dispatcher, which requires the request to be decorated with a scope. In the case of a version request, no scope exists, hence the request will fail.Also, the version service has been removed from the main branch on the upstream connector repo, so this its not good to rely on that.
FURTHER NOTES
The API previously responded with 502 Bad Gateway in cases where the metadata endpoint failed to response. This is no longer the case as the API will now always respond with 500 - in case of errors. However, the status code and a message will be passed on to the client for troubleshooting.
Closes #2277