Skip to content

Normalize CRLF line endings in install/PackageConfig.cmake.in #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

traversaro
Copy link
Contributor

The install/PackageConfig.cmake.in file is the only file in the repo with CRLF line endings, while all the other files use the regular LF line endings, as you can see with the command:

traversaro@IITBMP014LW012:~/zenoh-cpp$ grep -rIl --exclude-dir='.git' $'\r' .
./install/PackageConfig.cmake.in

This is problematic when creating a patch that involves both install/PackageConfig.cmake.in and other files. For this reason, this PR proposes to normalize the install/PackageConfig.cmake.in file and use LF line endings also there.

The file content is not modified in any other way.

This PR is similar to eclipse-zenoh/zenoh-c#1005, as the same problem was also in the zenoh-c repo.

Copy link

PR missing one of the required labels: {'bug', 'internal', 'breaking-change', 'dependencies', 'new feature', 'documentation', 'enhancement'}

@DenisBiryukov91 DenisBiryukov91 added the bug Something isn't working label Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants