Skip to content

remove deprecated AdvancedPublisherOptions::SampleMissDetectionOptions::heartbeat_period_ms field #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove deprecated AdvancedPublisherOptions::SampleMissDetectionOptions::heartbeat_period_ms field #519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions include/zenoh/api/ext/session_ext.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,16 +313,6 @@ class SessionExt {

/// Configure last sample miss detection through sporadic or periodic heartbeat.
std::variant<HeartbeatNone, HeartbeatPeriodic, HeartbeatSporadic> heartbeat = HeartbeatNone{};
/// @warning This API is deprecated and will be removed in future releases. Use `heartbeat` instead.
///
/// The period of publisher periodic heartbeats in ms. When this option is set and heartbeat mode is set to
/// `HeartbeatNone`, the behavior is the same as `HeartbeatPeriodic` with the period is set to
/// heartbeat
///
/// This option is ignored if heartbeat mode is not set to `HeartbeatNone`.
///
/// Do not use this option, if is temporary left for backward compatibility and will be removed soon
std::optional<uint64_t> heartbeat_period_ms = {};

/// @name Methods

Expand Down Expand Up @@ -384,12 +374,6 @@ class SessionExt {
} else {
opts.sample_miss_detection.heartbeat_mode =
::ze_advanced_publisher_heartbeat_mode_t::ZE_ADVANCED_PUBLISHER_HEARTBEAT_MODE_NONE;
if (this->sample_miss_detection->heartbeat_period_ms.has_value()) {
opts.sample_miss_detection.heartbeat_mode =
::ze_advanced_publisher_heartbeat_mode_t::ZE_ADVANCED_PUBLISHER_HEARTBEAT_MODE_PERIODIC;
opts.sample_miss_detection.heartbeat_period_ms =
this->sample_miss_detection->heartbeat_period_ms.value();
}
}
}
opts.publisher_detection_metadata = zenoh::interop::as_loaned_c_ptr(this->publisher_detection_metadata);
Expand Down
Loading