Add VMware Workstation Player to virtualization #19
Conversation
|
Any chance of this getting merged? |
|
🔔 ping! |
|
Can you rebase and make sure the tests pass now? |
…into feature/add-vmware-player-to-virtualization
bittner
force-pushed
the
feature/add-vmware-player-to-virtualization
branch
from
ea45b43 to
1dae792
Compare
bittner
force-pushed
the
feature/add-vmware-player-to-virtualization
branch
from
7d17314 to
e39396b
Compare
|
All lights are green, yay! Sorry that I just pulled instead of rebasing. I hope it's fine anyway. |
|
This is ready for merging. ping! 🔔 |
|
|
||
| case $::operatingsystem { | ||
| 'Debian', 'Ubuntu': { | ||
| validate_string($version, $urlbase, $package) |
There was a problem hiding this comment.
Can we switch to puppet 4 type validations?
There was a problem hiding this comment.
What would that look like? (Sorry!)
There was a problem hiding this comment.
Ah, type hinting, okay. That's the somewhat
class software::virtualization::vmware (
Enum['present', 'absent'] $ensure = $software::params::software_ensure,
String $version = $software::params::vmware_version,
String $url = $software::params::vmware_urlbase,
String $package = $software::params::vmware_package,
) inherits software::params {There may be some types better suited for (semantic) version and URL than String, and Optional[] probably needs to be wrapped around some. What's your preference?
Hmmm ... (I'm trying to avoid the "I'm away from Puppet, currently" argument) 😏 🤐 😳
There was a problem hiding this comment.
Stdlib has some types, but other than that I usually stick with the built in ones.
https://github.com/puppetlabs/puppetlabs-stdlib/tree/master/types
|
|
||
| $vmware_installer = "/tmp/${package}" | ||
| $vmware_install_cmd = "${vmware_installer} --console --eulas-agreed --required" | ||
| $vmware_uninstall_cmd = "${vmware_installer} --uninstall-product=vmware-player --required" |
There was a problem hiding this comment.
IS this variable ever used? If you want it around for reference, use a comment
There was a problem hiding this comment.
We should ideally run this when ensure is absent.
These changes add the free VMware Workstation Player to the virtualization class.
Fixes issue #12.