feat(community): PEDAGO-2883 adding info modal #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoisTouchardEdifice
force-pushed
the
feat/peda/community-info-modal
branch
2 times, most recently
from
78e3040 to
97a75dd
Compare
# Conflicts: # src/framework/modules/communities/screens/home/screen.tsx # Conflicts: # src/framework/modules/communities/screens/home/screen.tsx
vmourot
force-pushed
the
feat/peda/community-info-modal
branch
from
97a75dd to
9178683
Compare
|
|
Il y a une petite précision à avoir : est-ce que ouvrir une notification de communautés doit changer de Tab (comme pour messagerie), ou s'ouvrir en tant que sous-page de Fil de nouveautés (comme pour blog) ? Si c'est la première option, il faut se baser sur le notif-handler du module mails. Je te laisse valider ça avec Gwendal. |
|
Je crois qu'il y a un souci de dimensionnement des tuiles : elles sont plus hautes que lorsque l'écran est chargé. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.