fix(common): #ENABLING-199, better check of dates type when importing resources into mongo #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resources into mongo
jenkinsEdificePublic
force-pushed
the
dev
branch
from
0a5f547 to
9066497
Compare
jenkinsEdificePublic
force-pushed
the
dev
branch
from
db67b8c to
5ee5de8
Compare
jenkinsEdificePublic
force-pushed
the
dev
branch
from
9b6eab3 to
1e458cb
Compare
jenkinsEdificePublic
force-pushed
the
dev
branch
from
c8e3dbd to
0b4715a
Compare
moustaphahennawi
force-pushed
the
dev
branch
from
419701e to
fb65130
Compare
jenkinsEdificePublic
force-pushed
the
dev
branch
from
96df211 to
7576bf7
Compare
benjaminperez
force-pushed
the
dev
branch
2 times, most recently
from
f1a5cb7 to
8bba70d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the migration from Vertx 3 to Vertx 4, the change in the method JsonObject.getString introduced a regression in the way we handle
modifiedandcreateddates in imported resources. This caused imported resources to not be editable.This PR changes the way we determine if a field in a JsonObject is a String to circumvent this problem.
Fixes
EN-199
Type of change
Please check options that are relevant.
Which packages changed?
Please check the name of the package you changed
Tests
Reminder
Security flaws
Performance impacts (think bulk !)
Unit tests were replayed
Unit tests were added and/or changed
I have updated the reminder for the version including my modifications
All done ! 😃