feat: add audience broker listener #901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabil-mansouri
force-pushed
the
feat-annoucement
branch
from
98252cb to
77b6b79
Compare
nabil-mansouri
force-pushed
the
feat-annoucement
branch
2 times, most recently
from
6077672 to
436b77c
Compare
juniorode
requested changes
Oct 3, 2025
audience/src/main/java/org/entcore/audience/services/impl/ConfigurableAudienceAccessFilter.java
Outdated
Show resolved
Hide resolved
audience/src/main/java/org/entcore/audience/services/impl/ConfigurableAudienceAccessFilter.java
Outdated
Show resolved
Hide resolved
audience/src/main/java/org/entcore/audience/services/impl/ConfigurableAudienceAccessFilter.java
Outdated
Show resolved
Hide resolved
audience/src/main/java/org/entcore/audience/services/impl/NatsBrokerAudienceAccessFilter.java
Outdated
Show resolved
Hide resolved
audience/src/main/java/org/entcore/audience/services/impl/NatsBrokerAudienceAccessFilter.java
Show resolved
Hide resolved
broker-parent/broker-proxy/src/main/java/org/entcore/broker/proxy/AudienceBrokerListener.java
Outdated
Show resolved
Hide resolved
jenkinsEdificePublic
force-pushed
the
develop-pedago
branch
from
9c72552 to
7fdad97
Compare
nabil-mansouri
force-pushed
the
develop-pedago
branch
from
23085a5 to
ea41c94
Compare
juniorode
requested changes
Oct 28, 2025
Contributor
juniorode
left a comment
juniorode
left a comment
There was a problem hiding this comment.
Dans ConfigurableAudienceAccessFilter en préparant une liste de BrokerPublisher on peut atterrir sur le même résultat avec moins de code et sans besoin de faire de la réflexion à chaque vérification d'accès. À discuter ensemble.
audience/src/main/java/org/entcore/audience/services/impl/ConfigurableAudienceAccessFilter.java
Outdated
Show resolved
Hide resolved
audience/src/main/java/org/entcore/audience/services/impl/NatsBrokerAudienceAccessFilter.java
Outdated
Show resolved
Hide resolved
broker-parent/broker-api/src/main/java/org/entcore/broker/api/BrokerProxyFactory.java
Outdated
Show resolved
Hide resolved
juniorode
approved these changes
Oct 30, 2025
hleger-edifice
force-pushed
the
feat-annoucement
branch
from
009193b to
6acda7b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ce commit ajoute plusieurs choses:
Fixes
(Enter here Jira or Redmine ticket(s) links)
Type of change
Please check options that are relevant.
Which packages changed?
Please check the name of the package you changed
Tests
Reminder
Security flaws
Performance impacts (think bulk !)
Unit tests were replayed
Unit tests were added and/or changed
I have updated the reminder for the version including my modifications
All done ! 😃