Decouple message processing and handling #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a larger refactor of the sidebar, this piece decouples message production from their handlers. Introduces an observer pattern to subscribe to notifications. When the server receives a notification it notifies any subscribers
tomgeorge
commented
Aug 28, 2025
ericdallo
previously approved these changes
Aug 28, 2025
joaopluigi
previously approved these changes
Aug 28, 2025
lua/eca/sidebar.lua
Outdated
| instance._response_start_time = 0 | ||
| instance._max_response_length = 50000 -- 50KB max response | ||
|
|
||
| require("eca.observer").subscribe(id, make_handler(instance)) |
There was a problem hiding this comment.
why is make_handlerabstracted to a function? Couldn't that be defined inline?
ericdallo
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a larger refactor of the sidebar, this piece decouples message
production from their handlers. Introduces an observer pattern to
subscribe to notifications. When the server receives a notification it
notifies any subscribers