Skip to content

Conversation

@DawoudSheraz
Copy link

@DawoudSheraz DawoudSheraz commented Jun 20, 2025

Merge the following PR changes into teak/indigo so that a11y fixups become part of v4.

arbirali and others added 5 commits June 4, 2025 15:59
* fix: Toggle the theme on pressing the enter key

* fix: Fix linter issue

* feat: Adds accessible name to the theme tollger

* fix: add test-case for coverage 100%

* chore: resolves lint issues

---------

Co-authored-by: hinakhadim <hina.khadim@arbisoft.com>
* feat: Header - Focus order meaning - Open Edx Demo Course

* refactor: unify responsive rendering using existing Responsive component

* test: update test to handle conditional rendering logic
@codecov
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.58%. Comparing base (38d2651) to head (73b1a5d).
Report is 1 commits behind head on teak/indigo.

Files with missing lines Patch % Lines
src/ThemeToggleButton.jsx 88.88% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           teak/indigo      #32      +/-   ##
===============================================
+ Coverage        64.77%   68.58%   +3.80%     
===============================================
  Files               49       49              
  Lines              477      487      +10     
  Branches           106      110       +4     
===============================================
+ Hits               309      334      +25     
+ Misses             165      150      -15     
  Partials             3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DawoudSheraz DawoudSheraz merged commit c03a2a0 into teak/indigo Jun 24, 2025
5 of 6 checks passed
ahmed-arb pushed a commit that referenced this pull request Jul 8, 2025
* fix: Add visible titles to image-based links
* feat: enhance accessibility by adding descriptive label to theme toggle (#29)
* feat: Header - Focus order meaning - Open Edx Demo Course (#30)
* feat: Header - Focus order meaning - Open Edx Demo Course
* refactor: unify responsive rendering using the existing Responsive component

Co-authored-by: Rahat Ali <rahat.ali@arbisoft.com>
Co-authored-by: hinakhadim <hina.khadim@arbisoft.com>
ahmed-arb pushed a commit that referenced this pull request Jul 11, 2025
* fix: Add visible titles to image-based links
* feat: enhance accessibility by adding descriptive label to theme toggle (#29)
* feat: Header - Focus order meaning - Open Edx Demo Course (#30)
* feat: Header - Focus order meaning - Open Edx Demo Course
* refactor: unify responsive rendering using the existing Responsive component

Co-authored-by: Rahat Ali <rahat.ali@arbisoft.com>
Co-authored-by: hinakhadim <hina.khadim@arbisoft.com>
ahmed-arb pushed a commit that referenced this pull request Jul 16, 2025
* fix: Add visible titles to image-based links
* feat: enhance accessibility by adding descriptive label to theme toggle (#29)
* feat: Header - Focus order meaning - Open Edx Demo Course (#30)
* feat: Header - Focus order meaning - Open Edx Demo Course
* refactor: unify responsive rendering using the existing Responsive component

Co-authored-by: Rahat Ali <rahat.ali@arbisoft.com>
Co-authored-by: hinakhadim <hina.khadim@arbisoft.com>
ahmed-arb pushed a commit that referenced this pull request Jul 16, 2025
* fix: Add visible titles to image-based links
* feat: enhance accessibility by adding descriptive label to theme toggle (#29)
* feat: Header - Focus order meaning - Open Edx Demo Course (#30)
* feat: Header - Focus order meaning - Open Edx Demo Course
* refactor: unify responsive rendering using the existing Responsive component

Co-authored-by: Rahat Ali <rahat.ali@arbisoft.com>
Co-authored-by: hinakhadim <hina.khadim@arbisoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants