-
Couldn't load subscription status.
- Fork 18
feat!: upgrade to ulmo #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BREAKING CHANGE: Add support for react v18
* fix: Add visible titles to image-based links * feat: enhance accessibility by adding descriptive label to theme toggle (#29) * feat: Header - Focus order meaning - Open Edx Demo Course (#30) * feat: Header - Focus order meaning - Open Edx Demo Course * refactor: unify responsive rendering using the existing Responsive component Co-authored-by: Rahat Ali <rahat.ali@arbisoft.com> Co-authored-by: hinakhadim <hina.khadim@arbisoft.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ulmo/indigo #34 +/- ##
===============================================
- Coverage 68.75% 68.58% -0.17%
===============================================
Files 48 49 +1
Lines 432 487 +55
Branches 97 110 +13
===============================================
+ Hits 297 334 +37
- Misses 132 150 +18
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some screenshots of the impact and any next action items we might require.
Done. |
This PR is to sync teak/Indigo's changes with upstream master. We're doing this now to bring design token changes from upstream, the lack of which is currently failing our MFE build.
There are no build issues anymore, but there are styling/layout problems. Probably because we need to use design tokens in Indigo-related styling. I would create a follow-up PR for those changes.
Fixes: overhangio/tutor#1249