Skip to content

Conversation

@ahmed-arb
Copy link

@ahmed-arb ahmed-arb commented Jul 11, 2025

This PR is to sync teak/Indigo's changes with upstream master. We're doing this now to bring design token changes from upstream, the lack of which is currently failing our MFE build.

There are no build issues anymore, but there are styling/layout problems. Probably because we need to use design tokens in Indigo-related styling. I would create a follow-up PR for those changes.

Screenshot 2025-07-11 at 6 47 42 PM Screenshot 2025-07-11 at 6 47 54 PM

Fixes: overhangio/tutor#1249

hinakhadim and others added 6 commits July 11, 2025 14:29
BREAKING CHANGE: Add support for react v18
* fix: Add visible titles to image-based links
* feat: enhance accessibility by adding descriptive label to theme toggle (#29)
* feat: Header - Focus order meaning - Open Edx Demo Course (#30)
* feat: Header - Focus order meaning - Open Edx Demo Course
* refactor: unify responsive rendering using the existing Responsive component

Co-authored-by: Rahat Ali <rahat.ali@arbisoft.com>
Co-authored-by: hinakhadim <hina.khadim@arbisoft.com>
@ahmed-arb ahmed-arb deleted the branch ulmo/indigo July 14, 2025 06:49
@ahmed-arb ahmed-arb closed this Jul 14, 2025
@ahmed-arb ahmed-arb reopened this Jul 14, 2025
@ahmed-arb ahmed-arb deleted the branch ulmo/indigo July 15, 2025 12:48
@ahmed-arb ahmed-arb closed this Jul 15, 2025
@ahmed-arb ahmed-arb reopened this Jul 15, 2025
@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 68.58%. Comparing base (c63da30) to head (123f579).
Report is 1 commits behind head on ulmo/indigo.

Files with missing lines Patch % Lines
src/ThemeToggleButton.jsx 66.03% 18 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           ulmo/indigo      #34      +/-   ##
===============================================
- Coverage        68.75%   68.58%   -0.17%     
===============================================
  Files               48       49       +1     
  Lines              432      487      +55     
  Branches            97      110      +13     
===============================================
+ Hits               297      334      +37     
- Misses             132      150      +18     
  Partials             3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ahmed-arb ahmed-arb marked this pull request as ready for review July 16, 2025 09:00
@ahmed-arb ahmed-arb requested a review from DawoudSheraz July 16, 2025 09:01
Copy link

@DawoudSheraz DawoudSheraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some screenshots of the impact and any next action items we might require.

@ahmed-arb
Copy link
Author

Please add some screenshots of the impact and any next action items we might require.

Done.

@ahmed-arb ahmed-arb merged commit 273b244 into ulmo/indigo Jul 16, 2025
6 checks passed
@ahmed-arb ahmed-arb deleted the ahmed/upgrade-to-ulmo branch July 16, 2025 09:55
@ahmed-arb ahmed-arb restored the ahmed/upgrade-to-ulmo branch July 16, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants