Workaround poor reparse test performance and #1240#1268
Merged
timsueberkrueb merged 2 commits intomasterfrom Dec 17, 2025
Merged
Workaround poor reparse test performance and #1240#1268timsueberkrueb merged 2 commits intomasterfrom
timsueberkrueb merged 2 commits intomasterfrom
Conversation
This reverts commit 9755de4.
phischu
approved these changes
Dec 17, 2025
Collaborator
phischu
left a comment
There was a problem hiding this comment.
Yes, I think this amount of testing is sufficient.
Contributor
Author
|
With this PR, runtime for the internal tests still increases from ~3.5m to 7m. I could select an even smaller subset if you like. |
Contributor
I just noticed this in #1170 cc @timsueberkrueb
|
Contributor
... oh, => #1274 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


There are two issues related to the core reparse tests that currently slow down our development:
This PR