Skip to content

Workaround poor reparse test performance and #1240#1268

Merged
timsueberkrueb merged 2 commits intomasterfrom
speed-up-reparse-tests
Dec 17, 2025
Merged

Workaround poor reparse test performance and #1240#1268
timsueberkrueb merged 2 commits intomasterfrom
speed-up-reparse-tests

Conversation

@timsueberkrueb
Copy link
Contributor

@timsueberkrueb timsueberkrueb commented Dec 17, 2025

There are two issues related to the core reparse tests that currently slow down our development:

  1. They take a long time to execute because the core parser is very slow. The full test suite currently takes ~13m in CI
  2. Since separating out the reparse tests from the rest of the test suite we sometimes see long-running (likely diverging) test execution (see Investigate long running "Internal Tests & Verify Binary" CI #1240). The exact cause is still unclear, but I hypothesize the issue will disappear by reverting this change.

This PR

  • runs reparse tests only on the "benchmarks" subset of the full test suite
  • reverts the separation of the reparse test from the remaining internal tests

Copy link
Collaborator

@phischu phischu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this amount of testing is sufficient.

@timsueberkrueb
Copy link
Contributor Author

With this PR, runtime for the internal tests still increases from ~3.5m to 7m. I could select an even smaller subset if you like.

Copy link
Contributor

@jiribenes jiribenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timsueberkrueb timsueberkrueb merged commit 68bf2a8 into master Dec 17, 2025
16 of 21 checks passed
@timsueberkrueb timsueberkrueb deleted the speed-up-reparse-tests branch December 17, 2025 10:48
@jiribenes
Copy link
Contributor

Screenshot 2025-12-17 at 15 35 28 I just noticed this in #1170 cc @timsueberkrueb

@jiribenes
Copy link
Contributor

jiribenes commented Dec 17, 2025

Screenshot 2025-12-17 at 15 36 51

... oh, separateTests has "effekt.StdlibChezCPSTests",
but it's stdlibchezSCHEMEcpstests.

=> #1274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants