update models to validate with lates bids model shcema validator #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial capitals in JSON keys * snake_case for variables * AutoContrasts for dataset-level analysis * High-pass filter cutoff
* Initial capitals in JSON keys * snake_case for variables * AutoContrasts for dataset-level analysis * High-pass filter cutoff Additionally, moved Split transformation to subject level, eliminating session-level step
effigies
reviewed
Nov 16, 2018
| "Steps": [ | ||
| { | ||
| "Level": "run", | ||
| "Level": "Run", |
There was a problem hiding this comment.
@tyarkoni Was the desire to turn all strings into CamelCase, or just keys? As levels match with BIDS-Apps analysis_level arguments, I thought it made sense to leave these lowercase.
effigies
pushed a commit
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.