Skip to content

[Snyk] Security upgrade egg from 1.21.0 to 2.0.0 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade egg from 1.21.0 to 2.0.0 #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"config"
],
"dependencies": {
"egg": "^1.0.0-rc.3",
"egg": "^2.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This upgrade to egg v2 is a major change with breaking changes. To ensure the project continues to work correctly, other dependencies and project configuration must be updated for compatibility.

The following changes are necessary:

  1. Update Node.js Engine Requirement: egg v2 requires Node.js >= 8. The engines field in package.json should be updated accordingly.
  2. Update egg-* Dependencies: The following dependencies are likely incompatible with egg v2 and need to be upgraded. You can use a tool like npm-check-updates or run npm run autod (if configured for this) to find the latest compatible versions.
    • egg-alinode: ^1.1.0
    • egg-oss: ^1.0.1
  3. Update egg-* Dev Dependencies: The tooling also needs to be updated:
    • egg-bin: ^2.4.0
    • egg-mock: ^3.2.0

Please address these updates in this PR to ensure the security fix is applied to a working application. Without these changes, the project will likely fail to build, test, or run correctly.

"egg-alinode": "^1.1.0",
"egg-mysql": "^2.0.0",
"egg-oss": "^1.0.1",
Expand Down