Skip to content

[Snyk] Security upgrade egg from 1.21.0 to 3.16.0 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade egg from 1.21.0 to 3.16.0 #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"config"
],
"dependencies": {
"egg": "^1.0.0-rc.3",
"egg": "^3.16.0",
Copy link

@gemini-code-assist gemini-code-assist bot Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Upgrading egg from ^1.0.0-rc.3 to ^3.16.0 is a major version jump (v1 to v3) that introduces significant breaking changes. This will break the project unless other dependencies are also updated.

Here are the critical changes required for this upgrade to work:

  1. Node.js Version: egg v3 requires Node.js ^16.17.0 || ^18.12.0 || >=20.0.0. The engines field in package.json (line 33) must be updated. I recommend:

    "engines": {
  "node": ">=16.0.0"
}

  2. Development Dependencies: The devDependencies (lines 22-31) are incompatible with egg v3. They need to be upgraded. For example:

    • egg-bin: ^2.4.0 -> ^5.x
    • egg-mock: ^3.2.0 -> ^5.x
    • eslint-config-egg: ^3.2.0 -> ^12.x

  3. Other egg Plugins: The other egg plugins in dependencies (lines 17-20) are also likely incompatible and will need to be updated to their latest versions compatible with egg v3. This includes egg-alinode, egg-mysql, egg-oss, and egg-view-nunjucks.

Merging this PR as-is will result in a broken build. It is strongly recommended to address these dependency incompatibilities as part of this PR to keep the main branch stable.

"egg-alinode": "^1.1.0",
"egg-mysql": "^2.0.0",
"egg-oss": "^1.0.1",
Expand Down