Avoid using memcpy for non-POD elements #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a mirror repository, PR must be sent to https://bitbucket.org/eigen/eigen |
ZL-Su
approved these changes
Oct 6, 2018
|
@weimingzha0 care to make the PR in the upstream bitbucket repo ? |
kangzixiang
approved these changes
Jun 12, 2019
fwyzard
pushed a commit
to fwyzard/eigen-git-mirror
that referenced
this pull request
Aug 17, 2021
…a4f8269463207c4fee Re-adding last commit of "Re-import and update of Eigen patches for CUDA" eigenteam#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using memcpy for non-POD elements by returning "true", which will force the executor to call evalScalar() to copy the elements properly.