Skip to content

Adding key signatures to generated chorales #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding key signatures to generated chorales #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions voicing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ def voiceProgression(key, chordProgression):
return list(reversed(ret)), totalCost


def generateScore(chords, lengths=None, ts="4/4"):
def generateScore(chords, lengths=None, ts="4/4", key='C'):
"""Generates a four-part score from a sequence of chords.

Soprano and alto parts are displayed on the top (treble) clef, while tenor
Expand All @@ -215,8 +215,8 @@ def generateScore(chords, lengths=None, ts="4/4"):
voices[2].append(tenor)
voices[3].append(bass)

female = Part([TrebleClef(), TimeSignature(ts), voices[0], voices[1]])
male = Part([BassClef(), TimeSignature(ts), voices[2], voices[3]])
female = Part([TrebleClef(), TimeSignature(ts), Key(key), voices[0], voices[1]])
male = Part([BassClef(), TimeSignature(ts), Key(key), voices[2], voices[3]])
score = Score([female, male])
return score

Expand All @@ -241,7 +241,7 @@ def generateChorale(chorale, lengths=None, ts="4/4"):
for key, chords in lines:
phrase, _ = voiceProgression(key, chords)
progression.extend(phrase)
score = generateScore(progression, lengths, ts)
score = generateScore(progression, lengths, ts, key)
return score


Expand Down