bk: support packaging for PRs too

[v1v]

Motivation/summary

Use the BK PR Bot to run the apm-server-package on PRs too.

This should help with detecting breaking changes in the Unified Release before merging when using forked PRs. The only way to test that currently is by using a feature branch in the upstream.

Checklist

• Update CHANGELOG.asciidoc
• Documentation has been updated

For functional changes, consider:

• Is it observable through the addition of either logging or metrics?
• Is its use being published in telemetry to enable product improvement?
• Have system tests been added to avoid regression?

How to test these changes

Related issues

[github-actions]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[fr4nc1sc0-r4m0n]

I probably don't have enough context here, so my apologies if I say something wrong in advance. Is this filter with the skip and cancel flags allowing only executions when a PR is created by the elasticmachine service user but not when a release or main branch as it does before?

[v1v]

I don't follow your question.

If you mean about filter_condition, that's the one that was copied from the Elastic Agent, unfortunately when I asked about the specifics I dind't get a clear answer. I think elasticmachine was used as part of the BK PR Bot service, hence that was needed in the filter_condition. If you search for similar configurations you can see we follow the same pattern.

If you ask about skip_intermediate_builds or cancel_intermediate_builds_branch_filter, they are independent of the filtercondition.

If you go to this private link [only for Elastic employees], you can see what those settings do:

• filter_condition: - (Optional, Default: "") The condition to evaluate when deciding if a build should run. More details available in the Buildkite documentation.
• cancel_intermediate_builds: (Optional, Default: False) A boolean to enable automatically cancelling any running builds on the same branch when a new build is created.
• cancel_intermediate_builds_branch_filter: (Optional, Default: "") Limit which branches build cancelling applies to, for example !master will ensure that the master branch won't have it's builds automatically cancelled.
• skip_intermediate_builds: (Optional, Default: True) A boolean to enable automatically skipping any unstarted builds on the same branch when a new build is created.
• skip_intermediate_builds_branch_filter: (Optional, Default: "") Limit which branches build skipping applies to, for example !master will ensure that the master branch won't have it's builds automatically skipped.

Let me know If I clarify your question