Description
Hello!
Following the recommendations described in the article
How to create custom connectors for Elasticsearch, I am opening this issue.
I am working on the connector development in this fork.
I have some doubts about:
-
I would like to confirm if dependencies must be allocated in the
framework.txt
I couldn't find anyrequirements.txt
-
Regarding the tests, I found information in the article "How to Create Custom Connectors for Elasticsearch" about their location. It mentions they are in the path
connectors/source/test
(referenced here: https://www.elastic.co/search-labs/blog/how-to-create-customized-connectors-for-elasticsearch#acceptance-criteria-for-contributing-connectors). However, that path does not exist. I assume this has changed, and they are now located in thetest/sources
folder. I bring this up because in the following document: https://github.com/elastic/connectors/blob/main/docs/CONTRIBUTING.md#acceptance-criteria. It is stated that any modification outside theconnectors/sources
folder will be rejected. -
I am using the library
azure-storage-file-datalake==12.17.0
, which has compatibility issues withazure-storage-blob==12.19.1
, used in other connectors. What is a better option? : Should I updateazure-storage-blob
? Or should I downgradeazure-storage-file-datalake
?
For now, I downgradedazure-storage-file-datalake
used by Onelake connector to 12.14.0 version.
I would also appreciate some feedback on:
Tests
Connector implementation
Please let me know if you find anything else that can be improved.