Skip to content

Fix example for creating realm. #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

rgshenoy
Copy link

Without the fully qualified path, user faces multiple errors when updating the user setting in ECH console. For example xpack.security is not directly editable in ECH, so when older example is directly used, it errors out.

image

Without the fully qualified path, user faces multiple errors. For example xpack.security is not directly editable in ECH.
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
cc251d0

Please, read and sign the above mentioned agreement if you want to contribute to this project

@bmorelli25 bmorelli25 closed this May 20, 2025
@bmorelli25 bmorelli25 reopened this May 20, 2025
@bmorelli25 bmorelli25 requested a review from a team as a code owner May 20, 2025 21:21
@eedugon
Copy link
Contributor

eedugon commented May 21, 2025

@rgshenoy , thanks for flagging this! I now see the bug. authc wasn't properly indented as part of security.

IMO the original structure looks a bit better than your proposal, but it's just a matter of taste.

Would you please update the PR to look like...

xpack:
  security:
    authc:
      realms:
        oidc:
          oidc1:
            order: 2
            ...

If i'm not mistaken that should work in ECH without problems.

@shainaraskas , what do you think?

@shainaraskas
Copy link
Collaborator

@rgshenoy , thanks for flagging this! I now see the bug. authc wasn't properly indented as part of security.

IMO the original structure looks a bit better than your proposal, but it's just a matter of taste.

Would you please update the PR to look like...

xpack:
  security:
    authc:
      realms:
        oidc:
          oidc1:
            order: 2
            ...

If i'm not mistaken that should work in ECH without problems.

@shainaraskas , what do you think?

+1 I believe this is more consistent with our other docs as well

@eedugon eedugon added bug Something isn't working Team:Admin Issues owned by the Admin Docs Team labels May 26, 2025
@eedugon
Copy link
Contributor

eedugon commented May 26, 2025

Closing this in favor of #1493

@rgshenoy : thanks a lot for sharing this. We also had kibana configuration examples in the same page incorrect. I've included all changes in the new PR.

@eedugon eedugon closed this May 26, 2025
eedugon added a commit that referenced this pull request May 27, 2025
…1493)

This solves a bug discovered @rgshenoy in
#1416
Replaces #1416

Some indentation in the yaml configuration for Elasticsearch and Kibana
was incorrect. We have fixed it and aligned the format with the other
OIDC document.

Note that while reviewing all other examples in other realms (LDAP,
SAML, etc) there's no alignment at all in the format of the suggested
yaml settings. It might be good to align them in a separate PR, although
it's not really an issue or important.

cc: @shainaraskas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Team:Admin Issues owned by the Admin Docs Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants