Skip to content

Update ece-manage-capacity.md #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update ece-manage-capacity.md #1418

wants to merge 4 commits into from

Conversation

frconil
Copy link
Contributor

@frconil frconil commented May 15, 2025

CPU quotas are not updated, and cannot be set to -1 (disable CPU hard limit) when the underlying container platform is podman.

cc @kunisen

@eedugon eedugon self-assigned this May 22, 2025
@eedugon eedugon requested a review from a team May 22, 2025 09:00
@eedugon eedugon added the Team:Admin Issues owned by the Admin Docs Team label May 22, 2025
@eedugon
Copy link
Contributor

eedugon commented May 23, 2025

thanks a lot for bringing this @frconil , and for sharing in private the reasoning behind not being able to customize the CPU quotas on Podman based installations.

As talked I'll tweak a bit the changes and share them with you before merging. I'd like to:

Update: both actions have been discarded, because:

  • Resource overrides might not be affected by this (system creates new containers and this limitation might not affect there. pending confirmation).
  • The banner at change capacity API (in the memory section) is in the right place, as it's the action that triggers CPU quotas to be re-calculated.

@eedugon
Copy link
Contributor

eedugon commented May 27, 2025

@kunisen , @frconil , I have a question about this change.

As far as I see in the private slack conversation shared by @frconil , what we want to explain in the docs is that disabling the CPU hard limit in Podman systems is not possible.

But we don't have any document that describes how to tweak the CPU hard limit (which is something we can do only in the advanced editor if i'm not mistaken).

Why are we proposing this change in the doc that talks about Allocators capacity configuration?
I was also thinking about the doc Resource Overrides, but that doc is focused on what the UI allows to override instances, and the UI doesn't show the CPU hard limit enable / disable option.

I'm totally ok with adding a message like:
CPU quotas cannot be disabled (CPU hard limit) or updated when running ECE on Podman.

But we need to ensure the message doesn't create confusion, as a reader running ECE on Docker might ask... and how can be disabled or updated in ECE running on Docker?

Any proposal to make this clearer?

Shouldn't this belong better (perhaps) to the Known Issues of ECE instead of the docs? Like explaining that CPU hard limit disabling doesn't really work on Podman systems?

@eedugon
Copy link
Contributor

eedugon commented May 27, 2025

Oh, I think the note is applicable to the allocator capacity change that @frconil was suggesting, because if the user changes the capacity of an allocator, the quotas won't be automatically updated for existing instances in Podman systems (is my understanding right?).

@eedugon
Copy link
Contributor

eedugon commented May 28, 2025

I've created a different PR for a different issue on the same page. We might get a small conflict when merged.

On this, we are still waiting to get some responses from dev, to understand better the implication of this limitation.

The text that I'm planning to propose will be similar to:

When running ECE on Podman, CPU quotas for existing instances cannot be removed (CPU hard limit) or updated. As a result, changing an allocator’s capacity won’t affect the CPU quotas of already running containers.

But we need to get confirmation if that's the expected outcome, like new / future instances really getting updated quota calculations or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Admin Issues owned by the Admin Docs Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants