Skip to content

Manage data -> Data migration to ECH or ECE updated #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 27, 2025

Conversation

eedugon
Copy link
Contributor

@eedugon eedugon commented May 19, 2025

When working on the issue #1391 I realized that the migration guide was a bit outdated and had multiple important issues to address.

I have refined the content and applied major updates.

Updated docs:

Summary of fixes and changes:

  • Internal / system indices migration based on snapshot was incorrect -> feature states should be used.

  • Internal / system indices migration based on reindexing was incorrect -> the procedure was faulty and needed extra love and research. But considering that based on Elasticsearch docs we state that from 8.0 onwards, feature states are the only way to backup and restore system indices and system data streams, I have removed the reindex option for this.

  • Snapshot repository creation for ECE was invalid, as users shouldn't create a repository for data migration at ECE-level, but directly at deployment-level (this is a gap in our docs as we don't have specific ECE docs to create custom repos only at deployment level) -> The ECH doc is valid for this, so ECE users can follow the ECH doc to create a custom repo at deployment level.

  • Added a lot of links to other relevant documents of the new IA. The intention of this document is to feel like a narrative document explaining what to do and how, but with links to the official snapshots or reindex documentation for more information.

  • For reindex method, I have added explanations and recommendations for mappings and index templates handling, without specific instructions (just pointers).

  • The previous doc presented the official doc about Backup Snapshot repositories in a context where it didn't belong. I've included a tip explaining a use case where that can be useful.

  • The previous doc suggested the usage of a url type repository in a way that felt incorrect (together with AWS / GCS / Azure keystore credentials which in my opinion cannot be related). I've added it as another possible use case (I'm still not 100% sure about this, and we have some contradictions in other documents that we have to address separately).

Closes: #1391

@eedugon eedugon changed the title Manage data -> Migration guide to ECH or ECE updated Manage data -> Data migration to ECH or ECE updated May 19, 2025
@eedugon eedugon added the Team:Admin Issues owned by the Admin Docs Team label May 22, 2025
@eedugon eedugon requested a review from a team May 22, 2025 08:55
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful and clear work as always! threw some nitpicks on there. I don't think there's anything major, but try to get that whitespace check notice to go away, and as long as @stefnestor gives this a green light, it's basically good to go

@@ -17,13 +17,17 @@ products:

# Migrate your {{es}} data

You might have switched to {{ech}} or {{ece}} for any number of reasons, and you’re likely wondering how to get your existing {{es}} data into your new infrastructure. Along with easily creating as many new deployments with {{es}} clusters that you need, you have several options for moving your data over. Choose the option that works best for you:
You might have switched to {{ech}} (ECH) or {{ece}} (ECE) for any number of reasons, and you’re likely wondering how to get your existing {{es}} data into your new infrastructure. Along with easily creating as many new deployments with {{es}} clusters that you need, you have several options for moving your data over. Choose the option that works best for you:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eedugon and others added 2 commits May 23, 2025 11:13
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from some issues to be opened for future work and one tiny comment, ready to go

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from some issues to be opened for future work and one tiny comment, ready to go

@eedugon eedugon enabled auto-merge (squash) May 27, 2025 21:05
@eedugon eedugon merged commit 37e54c2 into main May 27, 2025
5 of 6 checks passed
@eedugon eedugon deleted the restore_system_indices_fix branch May 27, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Admin Issues owned by the Admin Docs Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue]: Breaking Wrong Info on restoring system indices
2 participants