-
Notifications
You must be signed in to change notification settings - Fork 88
Adds information about the importance of adaptive allocations #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great! Left a couple of comments and suggestions.
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Thank you! I applied your suggestions in my latest commit. |
Thanks! I think there are a few different aspects to this we will want to cover (cc: @arisonl @shubhaat ) Adaptive resources is enabled (from the UI):
Adaptive resources is disabled (from the UI):
Adaptive allocations enabled (from the API):
Adaptive allocations disabled (from the API):
|
Some things struck me here:
Please disregard if the linked page contains the full details and we're happy to have general overview here :) |
Thank you @ppf2 and @leemthompo for all of your suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a minor suggestion, otherwise LGTM.
Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
📸 Preveiw
Description
This PR updates the Inference integration documentation to:
Related issue: #1393