-
Notifications
You must be signed in to change notification settings - Fork 89
ece hard limit and podman introduction #1511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny suggestions for you, otherwise good. assume we have validated that this is safe to share
|
||
## Disabling CPU quotas at deployment level [cpu-hard-limit] | ||
|
||
In addition to overriding resources for individual instances, you can also completely disable CPU limits for your deployment from the **Operations** section of the deployment UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from the Operations section of the deployment UI.
this is a tiny bit unclear and we probably need to specify the path they'd use to access this (i.e. where is the deployment ui)
* Open the **Operations** page of the deployment UI, and select **Turn off** in the `CPU hard limit` section. | ||
|
||
* Use the [advanced editor](./advanced-cluster-configuration.md), and in the **{{es}} cluster data** section, look for the : | ||
|
||
```yaml | ||
"resources": { | ||
"cpu": { | ||
"hard_limit": false | ||
} | ||
} | ||
``` | ||
|
||
This change doesn’t require a restart of the deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: each of these should probably be a couple of steps under their own heading (each bullet has 2 steps in it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny suggestions for you, otherwise good. assume we have validated that this is safe to share
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
This PR introduces the CPU hard limit configuration (enable / disable) within the Resource overrides page.
I have also refined the introduction of the page.
Preview:
The reason of adding this is:
hiding
this button of the UI.I have added warnings and implications of using this setting, and recommending to do it only when being guided by Support. Please share your thoughs.
This PR will also be aligned with #1418 for the Podman limitation.