-
Notifications
You must be signed in to change notification settings - Fork 110
Fix up 'phase actions' section #2076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The section looks so much better and easier to read with the added tables and extra context. Thank you for fixing it up! :)
I can see what you mean about it being tricky to combine
all the tables into one. But I think the last table that reflects availability for each action and phase combo is very useful and complements the standalone phase-focused tables.
manage-data/lifecycle/index-lifecycle-management/index-lifecycle.md
Outdated
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/index-lifecycle.md
Outdated
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/index-lifecycle.md
Outdated
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/index-lifecycle.md
Outdated
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/index-lifecycle.md
Outdated
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/index-lifecycle.md
Outdated
Show resolved
Hide resolved
|
||
| Action | Description | | ||
| --- | --- | | ||
| [Set Priority](elasticsearch://reference/elasticsearch/index-lifecycle-actions/ilm-set-priority.md) | Sets the priority level of the index, which determines the order in which indices are recovered following a node restart. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more general comment about action capitalization. The linked references all use sentence case, like Set priority
instead of Set Priority
. Should we be using the same in the tables here?
There's another discrepancy with hyphenation in Read-Only
and [Read only](https://www.elastic.co/docs/reference/elasticsearch/index-lifecycle-actions/ilm-readonly)
-- the latter should probably be Read-only
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure! Thanks a lot for catching that.
…le.md Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
…le.md Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
…le.md Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
…le.md Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
…le.md Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
…le.md Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
Based on feedback from Support, this PR:
Note: I wanted to have one large table showing all actions, their descriptions, and the phases in which they're available, but there are two problems:
Closes: #1559