-
Notifications
You must be signed in to change notification settings - Fork 113
Add python keyword search quickstart #2106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! I like the scope of it and it has a nice flow. I made some minor suggestions but some of them really are just preferences, so take or leave them as you see fit!
sorry the comments jump around 🫤 I added a screenshot for the first 2 paragraphs
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well written! :)) Only nitpicking, take in the suggestions if you want to.
Just out of curiosity, if this content wasn't taken as is, do we test this before we write or do we ask a dev to confirm if everything works correctly as stated here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for wading through all my suggestions! LGTM
Co-authored-by: ketkee-aryamane <ketkee.aryamane@elastic.co>
Co-authored-by: ketkee-aryamane <ketkee.aryamane@elastic.co>
I tested this all last night and had fun doing so! Generally a good idea to ensure everything we document works--either ourselves or with assistance, as you said. |
This PR aims to port content from https://www.elastic.co/getting-started/enterprise-search/build-an-application-on-top-of-elasticsearch into the https://www.elastic.co/docs/solutions/search/get-started section of the documentation.