Fix race condition in product check #8296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flobernd
added
8.x
Mpdreamz
requested changes
Aug 12, 2024
src/Elastic.Clients.Elasticsearch.Shared/Client/ElasticsearchClient.cs
Outdated
Show resolved
Hide resolved
src/Elastic.Clients.Elasticsearch.Shared/Client/ElasticsearchClient.cs
Outdated
Show resolved
Hide resolved
flobernd
commented
Aug 12, 2024
src/Elastic.Clients.Elasticsearch.Shared/Client/ElasticsearchClient.cs
Outdated
Show resolved
Hide resolved
Mpdreamz
approved these changes
Aug 12, 2024
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
LGTM!
Not sure if the
The type or namespace name 'Experimental' does not exist in the namespace 'Elastic.Clients.Elasticsearch' (are you missing an assembly reference?)
are related.
Member
Author
|
The tests are not fully updated after the breaking 8.13 release. Have to spend some time on that soon, to have reliable CI builds again. |
flobernd
added a commit
that referenced
this pull request
Aug 13, 2024
flobernd
added a commit
that referenced
this pull request
Aug 13, 2024
flobernd
added a commit
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition in the product check.
Closes #8268