Skip to content

[Backport 9.0] 9.0.1 fixes #8506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public override void Write(System.Text.Json.Utf8JsonWriter writer, Elastic.Clien

/// <summary>
/// <para>
/// Get data frame analytics jobs usage info.
/// Get data frame analytics job stats.
/// </para>
/// </summary>
[System.Text.Json.Serialization.JsonConverter(typeof(Elastic.Clients.Elasticsearch.MachineLearning.GetDataFrameAnalyticsStatsRequestConverter))]
Expand Down Expand Up @@ -206,7 +206,7 @@ internal GetDataFrameAnalyticsStatsRequest(Elastic.Clients.Elasticsearch.Seriali

/// <summary>
/// <para>
/// Get data frame analytics jobs usage info.
/// Get data frame analytics job stats.
/// </para>
/// </summary>
public readonly partial struct GetDataFrameAnalyticsStatsRequestDescriptor
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public override void Write(System.Text.Json.Utf8JsonWriter writer, Elastic.Clien

/// <summary>
/// <para>
/// Get datafeeds usage info.
/// Get datafeed stats.
/// You can get statistics for multiple datafeeds in a single API request by
/// using a comma-separated list of datafeeds or a wildcard expression. You can
/// get statistics for all datafeeds by using <c>_all</c>, by specifying <c>*</c> as the
Expand Down Expand Up @@ -168,7 +168,7 @@ internal GetDatafeedStatsRequest(Elastic.Clients.Elasticsearch.Serialization.Jso

/// <summary>
/// <para>
/// Get datafeeds usage info.
/// Get datafeed stats.
/// You can get statistics for multiple datafeeds in a single API request by
/// using a comma-separated list of datafeeds or a wildcard expression. You can
/// get statistics for all datafeeds by using <c>_all</c>, by specifying <c>*</c> as the
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public override void Write(System.Text.Json.Utf8JsonWriter writer, Elastic.Clien

/// <summary>
/// <para>
/// Get anomaly detection jobs usage info.
/// Get anomaly detection job stats.
/// </para>
/// </summary>
[System.Text.Json.Serialization.JsonConverter(typeof(Elastic.Clients.Elasticsearch.MachineLearning.GetJobStatsRequestConverter))]
Expand Down Expand Up @@ -163,7 +163,7 @@ internal GetJobStatsRequest(Elastic.Clients.Elasticsearch.Serialization.JsonCons

/// <summary>
/// <para>
/// Get anomaly detection jobs usage info.
/// Get anomaly detection job stats.
/// </para>
/// </summary>
public readonly partial struct GetJobStatsRequestDescriptor
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public override void Write(System.Text.Json.Utf8JsonWriter writer, Elastic.Clien
/// <para>
/// Discounted cumulative gain (DCG)
/// </para>
/// <para><see href="https://www.elastic.co/guide/en/elasticsearch/reference/8.18/search-rank-eval.html">Learn more about this API in the Elasticsearch documentation.</see></para>
/// <para><see href="https://www.elastic.co/docs/reference/elasticsearch/rest-apis/search-rank-eval#_discounted_cumulative_gain_dcg">Learn more about this API in the Elasticsearch documentation.</see></para>
/// </summary>
[System.Text.Json.Serialization.JsonConverter(typeof(Elastic.Clients.Elasticsearch.Core.RankEval.RankEvalMetricDiscountedCumulativeGainConverter))]
public sealed partial class RankEvalMetricDiscountedCumulativeGain
Expand Down Expand Up @@ -115,7 +115,7 @@ internal RankEvalMetricDiscountedCumulativeGain(Elastic.Clients.Elasticsearch.Se
/// <para>
/// Discounted cumulative gain (DCG)
/// </para>
/// <para><see href="https://www.elastic.co/guide/en/elasticsearch/reference/8.18/search-rank-eval.html">Learn more about this API in the Elasticsearch documentation.</see></para>
/// <para><see href="https://www.elastic.co/docs/reference/elasticsearch/rest-apis/search-rank-eval#_discounted_cumulative_gain_dcg">Learn more about this API in the Elasticsearch documentation.</see></para>
/// </summary>
public readonly partial struct RankEvalMetricDiscountedCumulativeGainDescriptor
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public override void Write(System.Text.Json.Utf8JsonWriter writer, Elastic.Clien
/// <para>
/// Mean Reciprocal Rank
/// </para>
/// <para><see href="https://www.elastic.co/guide/en/elasticsearch/reference/8.18/search-rank-eval.html#_mean_reciprocal_rank">Learn more about this API in the Elasticsearch documentation.</see></para>
/// <para><see href="https://www.elastic.co/docs/reference/elasticsearch/rest-apis/search-rank-eval#_mean_reciprocal_rank">Learn more about this API in the Elasticsearch documentation.</see></para>
/// </summary>
[System.Text.Json.Serialization.JsonConverter(typeof(Elastic.Clients.Elasticsearch.Core.RankEval.RankEvalMetricMeanReciprocalRankConverter))]
public sealed partial class RankEvalMetricMeanReciprocalRank
Expand Down Expand Up @@ -115,7 +115,7 @@ internal RankEvalMetricMeanReciprocalRank(Elastic.Clients.Elasticsearch.Serializ
/// <para>
/// Mean Reciprocal Rank
/// </para>
/// <para><see href="https://www.elastic.co/guide/en/elasticsearch/reference/8.18/search-rank-eval.html#_mean_reciprocal_rank">Learn more about this API in the Elasticsearch documentation.</see></para>
/// <para><see href="https://www.elastic.co/docs/reference/elasticsearch/rest-apis/search-rank-eval#_mean_reciprocal_rank">Learn more about this API in the Elasticsearch documentation.</see></para>
/// </summary>
public readonly partial struct RankEvalMetricMeanReciprocalRankDescriptor
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public override void Write(System.Text.Json.Utf8JsonWriter writer, Elastic.Clien
/// <para>
/// Precision at K (P@k)
/// </para>
/// <para><see href="https://www.elastic.co/docs/api/doc/elasticsearch/v9/operation/operation-rank-eval#k-precision">Learn more about this API in the Elasticsearch documentation.</see></para>
/// <para><see href="https://www.elastic.co/docs/reference/elasticsearch/rest-apis/search-rank-eval#k-precision">Learn more about this API in the Elasticsearch documentation.</see></para>
/// </summary>
[System.Text.Json.Serialization.JsonConverter(typeof(Elastic.Clients.Elasticsearch.Core.RankEval.RankEvalMetricPrecisionConverter))]
public sealed partial class RankEvalMetricPrecision
Expand Down Expand Up @@ -131,7 +131,7 @@ internal RankEvalMetricPrecision(Elastic.Clients.Elasticsearch.Serialization.Jso
/// <para>
/// Precision at K (P@k)
/// </para>
/// <para><see href="https://www.elastic.co/docs/api/doc/elasticsearch/v9/operation/operation-rank-eval#k-precision">Learn more about this API in the Elasticsearch documentation.</see></para>
/// <para><see href="https://www.elastic.co/docs/reference/elasticsearch/rest-apis/search-rank-eval#k-precision">Learn more about this API in the Elasticsearch documentation.</see></para>
/// </summary>
public readonly partial struct RankEvalMetricPrecisionDescriptor
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public override void Write(System.Text.Json.Utf8JsonWriter writer, Elastic.Clien
/// <para>
/// Recall at K (R@k)
/// </para>
/// <para><see href="https://www.elastic.co/guide/en/elasticsearch/reference/8.18/search-rank-eval.html#k-recall">Learn more about this API in the Elasticsearch documentation.</see></para>
/// <para><see href="https://www.elastic.co/docs/reference/elasticsearch/rest-apis/search-rank-eval#k-recall">Learn more about this API in the Elasticsearch documentation.</see></para>
/// </summary>
[System.Text.Json.Serialization.JsonConverter(typeof(Elastic.Clients.Elasticsearch.Core.RankEval.RankEvalMetricRecallConverter))]
public sealed partial class RankEvalMetricRecall
Expand Down Expand Up @@ -115,7 +115,7 @@ internal RankEvalMetricRecall(Elastic.Clients.Elasticsearch.Serialization.JsonCo
/// <para>
/// Recall at K (R@k)
/// </para>
/// <para><see href="https://www.elastic.co/guide/en/elasticsearch/reference/8.18/search-rank-eval.html#k-recall">Learn more about this API in the Elasticsearch documentation.</see></para>
/// <para><see href="https://www.elastic.co/docs/reference/elasticsearch/rest-apis/search-rank-eval#k-recall">Learn more about this API in the Elasticsearch documentation.</see></para>
/// </summary>
public readonly partial struct RankEvalMetricRecallDescriptor
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public override Elastic.Clients.Elasticsearch.Core.Search.InnerHits Read(ref Sys
continue;
}

if (propFields.TryReadProperty(ref reader, options, PropFields, static Elastic.Clients.Elasticsearch.Fields? (ref System.Text.Json.Utf8JsonReader r, System.Text.Json.JsonSerializerOptions o) => r.ReadValueEx<Elastic.Clients.Elasticsearch.Fields?>(o, typeof(Elastic.Clients.Elasticsearch.Serialization.SingleOrManyFieldsMarker))))
if (propFields.TryReadProperty(ref reader, options, PropFields, null))
{
continue;
}
Expand Down Expand Up @@ -180,7 +180,7 @@ public override void Write(System.Text.Json.Utf8JsonWriter writer, Elastic.Clien
writer.WriteProperty(options, PropCollapse, value.Collapse, null, null);
writer.WriteProperty(options, PropDocvalueFields, value.DocvalueFields, null, static (System.Text.Json.Utf8JsonWriter w, System.Text.Json.JsonSerializerOptions o, System.Collections.Generic.ICollection<Elastic.Clients.Elasticsearch.QueryDsl.FieldAndFormat>? v) => w.WriteCollectionValue<Elastic.Clients.Elasticsearch.QueryDsl.FieldAndFormat>(o, v, null));
writer.WriteProperty(options, PropExplain, value.Explain, null, null);
writer.WriteProperty(options, PropFields, value.Fields, null, static (System.Text.Json.Utf8JsonWriter w, System.Text.Json.JsonSerializerOptions o, Elastic.Clients.Elasticsearch.Fields? v) => w.WriteValueEx<Elastic.Clients.Elasticsearch.Fields?>(o, v, typeof(Elastic.Clients.Elasticsearch.Serialization.SingleOrManyFieldsMarker)));
writer.WriteProperty(options, PropFields, value.Fields, null, null);
writer.WriteProperty(options, PropFrom, value.From, null, null);
writer.WriteProperty(options, PropHighlight, value.Highlight, null, null);
writer.WriteProperty(options, PropIgnoreUnmapped, value.IgnoreUnmapped, null, null);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
// Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
// See the LICENSE file in the project root for more information.

using System.Collections.Generic;
using System.Text.Json.Serialization;

namespace Elastic.Clients.Elasticsearch.IndexManagement;

public partial class GetAliasResponse
Expand All @@ -17,5 +14,5 @@ public partial class GetAliasResponse
/// the client considers the response to be valid.
/// </para>
/// </summary>
public override bool IsValidResponse => base.IsValidResponse || Aliases.Count > 0;
public override bool IsValidResponse => base.IsValidResponse || Aliases?.Count > 0;
}