Add (experimental) native AOT support #8530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flobernd
commented
May 22, 2025
| @@ -36,6 +36,11 @@ protected override (string ResolvedUrl, string UrlTemplate, Dictionary<string, s | |||
| [JsonConverter(typeof(SearchRequestOfTConverterFactory))] | |||
| public partial class SearchRequest<TInferDocument> : SearchRequest | |||
| { | |||
| static SearchRequest() | |||
| { | |||
| DynamicallyAccessed.PublicConstructors(typeof(SearchRequestOfTConverter<TInferDocument>)); | |||
There was a problem hiding this comment.
We might have to generate this for all generic types that are using converter factories to make Activator.CreateInstance succeed even when T is a value type (e.g. if the user for some reason uses struct for top level documents).
Mpdreamz
approved these changes
May 22, 2025
| [JsonSerializable(typeof(ushort))] | ||
| [JsonSerializable(typeof(ushort?))] | ||
| [JsonSerializable(typeof(object))] | ||
| [JsonSerializable(typeof(string))] |
There was a problem hiding this comment.
Suprised this is needed in the transport we do the following:
To get all the defaults attached to our JsonSerializerContext
There was a problem hiding this comment.
There was a problem hiding this comment.
Nullable value types don't work out of the box with the combined DefaultJsonTypeInfoResolver. The other ones probably would work, but since this behavior is a bit of a blackbox to me, I rather define all these types explicitly.
flobernd
added a commit
that referenced
this pull request
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.